search

jneilliii / OctoPrint-PlotlyTempGraph

23 stars 7 forks source link

Seems to break your other plugin "Consolidate Temp Control" #13

Closed Misterke closed 3 years ago

Misterke commented 3 years ago

I used "Consolidate Temp Control" to combine the Control and Temp tabs, which worked fine, until I installed this PlotlyTempGraph. It seems to force Control and Temp back into separate tabs ...

jneilliii commented 3 years ago

I'll double check, but I think this may be a bug with core octoprint and replaced view models. When you go to the tab after it's broke out what is its url listed as in the address bar?

Misterke commented 3 years ago

The tab with the controls on it has as url: http:///2/#tab_plugin_consolidate_temp_control But there is no trace of temperature on that tab. The tab with the temperature on it is: http:///2/#tab_plugin_plotlytempgraph Note that the /2/ is because I have 2 instance of OctoPrint on the same pi for my 2 printers and haproxy forwards /1/ and /2/ to the appropriate ports of the 2 instances.

I am also running the Tab Order plugin to order the tabs and give them just a nice icon without text. I also have this plugin set to hide the actual Control tab if any would still exist.

Before I was also running Tempsgraph Plugin (https://github.com/1r0b1n0/OctoPrint-Tempsgraph) and that would play nice with the Consolidate Temp Control, but I also have some CSS tweaks to make the UI fit to the full width of my browser window and the Tempsgraph view would not adjust to that on initial load - only after doing some action in it. That's why I wanted to give yours a try and at least on the separate tab, it nicely uses all the available space - but I can't check what it would do when "consolidated" with the control tab ...

I like having a full-width temp-view on a separate tab better than a way too small one on the control tab, so I'll anyway stick with yours for now ;-)

jneilliii commented 3 years ago

By the way, my Consolidated Tabs plugin would allow you to combine this plugin and the Control tab, or any other tab for that matter. Might be a good alternative?

Misterke commented 3 years ago

@jneilliii , I've installed the Consolidated Tabs plugin, but it isn't really the combining I was looking for. I can't really put my finger on what it is, but it just doesn't ring my bell. Maybe it's having to set the size of the temp tab manually to get things to fit, maybe it's just my weird taste ... However, I have been getting used again to having them on separate tabs, so I'm happy enough.

Ah, and yes, the Consolidated Tabs plugin did seem to work with the PlotlyTempGraph, unlike the Consolidate Temp Control. So, that could indeed be a workaround for other people.

jneilliii commented 3 years ago

Ok, well I'll close this ticket then because consolidated tabs does work. In regard to sizing on that plugin's content, you only have to do it once and save and it's possible to get exactly the same results as the other plugin by enabling some of its settings (full width).