search

jneilliii / OctoPrint-PlotlyTempGraph

25 stars 7 forks source link

Second tool not showen #20

Closed EddyMI3d closed 3 years ago

EddyMI3d commented 3 years ago

Hello @jneilliii !

With the latest update (V 0.1.2), the second tool does not appear in the graph any more.

grafik

jneilliii commented 3 years ago

Can you try adding the second tool to the name map?

aerickson commented 3 years ago

I thought that this was a bug also, but I've got it working now.

It's hard to figure out the temperature names (I was missing 'actual'... in my plugin I don't add this). I think the previous behavior of displaying all is better/less confusing (with users adding a config entry if hiding a value is desired).

Is there a way to inspect the temperature names in the javascript console?

Thanks for all of your work. :)

jneilliii commented 3 years ago

I agree, this is less than ideal but number of users with multiple extruders is probably not that high. I will plan on figuring out a way to automatically pick up what is returned from the printer and add to the name map though.

EddyMI3d commented 3 years ago

Can you try adding the second tool to the name map?

Yes, that worked for me too. Thanks you

jneilliii commented 3 years ago

Adding note, that this also effects the Enclosure Plugin fork as sensors aren't automatically added to the graph anymore with the name map. Will be digging into this further over the weekend to remedy.

jneilliii commented 3 years ago

Thanks to a quick fix approach from @Dak0r I've just pushed the commit above to the rc branch and will release a 0.1.3rc1 version shortly that should resolve this issue. I still want to have the items not in the name map automatically added long-term, but that will take a little more work to complete. If you want to try it out and verify you can switch the plugin's release channel in OctoPrint's Software Update settings to Release Candidate and upgrade when prompted.