Graph not updating with UI Customizer

[kfrancis]

Love the plugin.

Since I installed UI Customizer, the graph doesn't update

[jneilliii]

Any errors in your developers tool's (F12) console tab? Don't know if @LazeMSS might know anything about this or not.

[jneilliii]

I just tested in my UI Customizer instance and the graph seems to be working. Will need more details.

[LazeMSS]

Also works on my development environments

[Dak0r]

I use Ui Customizer with the Flatly theme and everything seems to be fine on my setup

[kfrancis]

Hmm, I'll see what I can gather. I didn't see any errors, just some warnings that looks relevant (about temp).

[kfrancis]

Using theme: Discorded

Versions

• UI Customizer: v0.1.7.0
• Plotly: v0.1.2

Dev tools has messages like:

Did not bind view model TemperatureViewModel to target #temp since it does not exist
Did not bind view model TemperatureViewModel to target #temp_link since it does not exist

[kfrancis]

I would be comfortable letting @jneilliii in via octo-everywhere if that would help debug, just message me.

[kfrancis]

I'll note also that it's just the updating that's not working. The graph does generate correctly and can be interacted with normally. It can be refreshed when I hit F5, but otherwise doesn't:

[jneilliii]

Ah, this might be the temperature widget in UI Customizer interfering since my plugin replaces the default view model. I don't enable that in my instance. If you hide that in UI Customizer's settings does it work after refreshing the page?

[jneilliii]

@LazeMSS I think this could be relatively easy to fix using optional viewmodel dependency with this plugin's identifier, and redefining self.tempModel to use that parameter[index] if it exists. I'll do some testing when I get home tonight and submit a PR to UI Customizer if it works.

[LazeMSS]

@LazeMSS I think this could be relatively easy to fix using optional viewmodel dependency with this plugin's identifier, and redefining self.tempModel to use that parameter[index] if it exists. I'll do some testing when I get home tonight and submit a PR to UI Customizer if it works.

Awesome!

[jneilliii]

@kfrancis I couldn't message you via twitter. could you do a test for me and see if installing this version of the UICustomizer has any effect? OctoPrint settings > Plugin Manager > Get More > ...from URL.

https://github.com/jneilliii/OctoPrint-UICustomizer/archive/refs/heads/bugfix/plotlytempgraph.zip

[jneilliii]

I will say, even after enabling the temperature widget in UI Customizer the original version was still working for me, so this could potentially be a combination of multiple plugins causing this. I would be willing to connect to your instance to debug, just shoot me an email or reach out on the OctoPrint Discord server.

[kfrancis]

@kfrancis I couldn't message you via twitter. could you do a test for me and see if installing this version of the UICustomizer has any effect? OctoPrint settings > Plugin Manager > Get More > ...from URL.

https://github.com/jneilliii/OctoPrint-UICustomizer/archive/refs/heads/bugfix/plotlytempgraph.zip

Interestingly, that didn't install this plugin but the UI customizer was reinstalled. After doing that, it just seems to work now no matter if I have the default temp widget enabled or not.

[jneilliii]

Yeah, that is my fork of ui customizer with potential fix for the issue, although I'm not sure it was an issue to begin with. Would definitely resolve the error you posted I think though. @LazeMSS do you see any potential issues with that branch?

[LazeMSS]

No basically what you are doing is replacing the native temp model with plotlytempgraphViewModel if present - it looks nice and simple :)

[LazeMSS]

Do a PR

[jneilliii]

PR submitted.