search

jneilliii / OctoPrint-PrusaSlicerThumbnails

91 stars 20 forks source link

Exclude thumbnails from backup logic #121

Closed lifeisafractal closed 9 months ago

lifeisafractal commented 9 months ago

Skip backing up cached thumbnails if 'uploads' is excluded from the backup.

This should make sense for any reasonable use case. If you aren't backing up your gcode uploads, then the thumbnails are useless anyway, and the user likely is trying to keep down the size of their backup archives. If you are backing up your gcode, the thumbnail is likely a good deal smaller than the gcode and the user likely isn't too worried about the size of their backup archive and this will give a faithful snapshot of the state of Octoprint at the time of backup in reguards to gcode and thumbnails.

The discussion in #120 talked about making a new setting to exclude from backups and to default it to off. After thinking on it some more, using the 'uploads' as a cue is cleaner and will meet users' intuitive expectations. FWIW here is an implementation of the settings based option: https://github.com/jneilliii/OctoPrint-PrusaSlicerThumbnails/compare/master...lifeisafractal:OctoPrint-PrusaSlicerThumbnails:backup-exclude?expand=1

Fixes #120

jneilliii commented 9 months ago

very slick and I agree that the uploads exclusion there does make complete sense. thanks for your contribution.