Allow plugin to pull image

[edekeijzer]

It appeared a bit unnecessary to me to throw an error if the docker image isn't found on the system, if you could as well do a pull. Added a checkbox to settings, added an on_settings_save to trigger _get_image when settings are updated and trigger _pull_image from inside _get_image if the setting is enabled. Also changed the import docker to only importing from_env and some slightly more specific error handling, and a little bugfix where there would be an attempt to create a container if creating the Docker client did not succeed.

[TheSin-]

makes sense to me. Though I believe we are considering dropping docker support as it just complicates things. But that is still up for debate.

That being said it would be nice if the plugin could auto fetch for you.

[edekeijzer]

makes sense to me. Though I believe we are considering dropping docker support as it just complicates things. But that is still up for debate.

That being said it would be nice if the plugin could auto fetch for you.

I actually quite like the Docker option, my next enhancement would be to create the container on a remote Docker server over SSH (use the beefy homeserver for streaming instead of the RPi 3), but that will require some more testing as well as decent documentation.

[TheSin-]

that is why I originally liked it and this is a good use case for keeping it. Make a good HOWTO in the repo for this might be good, or a button in the setting when selecting docker?

[jneilliii]

Thanks for the contribution, totally makes sense to me as well.