search

jneilliii / OctoPrint-TabOrder

23 stars 7 forks source link

Icons #28

Closed leoheck closed 4 years ago

leoheck commented 4 years ago

Hi, where I can find a list of icons? I saw many pictures with icons, but not a list of them.

Can you please, share a link with this list or add it in README.md?

Or even better, why this plugin does not come with icons filled by default? I mean, if the user wants to change the text by and icon it clicks a checkbox, to enable an input field with a default icon there that can be changed too.

What do you think?

jneilliii commented 4 years ago

Pretty sure there's a link on the readme to fontawesome as well as clicking the info icon.

leoheck commented 4 years ago

The info icon was good but I had to take some time to understand the syntax, it is not straight forward especially if you don't know what to do. A note on readme will be good. I was not able to find the info on the readme. If it is under changelog it won't work since I was looking for info about the usage, not the changelog.

Well, this is my suggestion to improve it. Have a nice day.

jneilliii commented 4 years ago

Understood. I was trying to implement an icon selector option but haven't had much time to work on it.

jneilliii commented 4 years ago

If you don't mind testing for me that would be great. You can install a test version by using the url below in plugin manager. Let me know how it works out.

https://github.com/jneilliii/OctoPrint-TabOrder/archive/0.5.5.zip

leoheck commented 4 years ago

I am doing it right now.

leoheck commented 4 years ago

It looks promising dude! image

leoheck commented 4 years ago

I was able to replace all of my icons. I was using this version that starts with fa and they were replaced by something that starts with fas I don't know what this tag does but everything was set just easy. Dude, this is awesome. image

jneilliii commented 4 years ago

Great, glad it works as expected. I'll update the version and push an official release.

leoheck commented 4 years ago

Good. Thanks.

Leandro Heck

On Fri, Nov 1, 2019 at 11:57 PM jneilliii notifications@github.com wrote:

Great, glad it works as expected. I'll update the version and push an official release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jneilliii/OctoPrint-TabOrder/issues/28?email_source=notifications&email_token=AAJX7YDKV7S375UPPGAQHDTQRTUA3A5CNFSM4JFTWNIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4SGLY#issuecomment-549004079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJX7YFEBV2BIE5JBH76G3LQRTUA3ANCNFSM4JFTWNIA .