Uploaded UFP file not deleted from Plugin-Folder

[OllisGit]

Hi @jneilliii , I am starting analysing the "remove thumbnail-issue". So, I tested a "normal" case:

• Upload the ufp-file
• The ufp file is uploaded to "data/UltimakerFormatPackage/"
• Its extract to the data folder and the gcode-file is copied to uploads/folder

fine....but after deleting the gcode from the GUI, all files where delete, except the orig. ufp file.

Tested with: 1.4.0rc5, Python 2.7

Could you reproduce this behaviour?

BTW. Why do you store the gocde and ufp file in your plugin folder...it waste harddisc-space?

After upload:

After delete:

[jneilliii]

Just an oversight @OllisGit. It was my assumption that the DiskFileWrapper based on the docs moved the file instead of copy the file.

[jneilliii]

Should be fixed with commit https://github.com/jneilliii/OctoPrint-UltimakerFormatPackage/commit/a66166bd089fb8709df804d6c8a82d6dc8f77f3c and added to next release version #12

[OllisGit]

Morning @jneilliii ,

I tested the 0.1.4 branch.

• Removing the file via UI is now removing completely all files
• But why do you still keep the ufp.gcode file in the plugin folder. It is redundant and not needed (IMHO)

I tested also the FileManager plugin for moving gcode to a sub-folder. Unfortunately only the remove-event is passing the UFP-Plugin, the "FileAdded" event doesn't occourse....I think to solve the move image-issue (a.k.a. additional metadata), we need to analyse/improve the Octoprint-Core code or patching all plugins which were using file move.

[jneilliii]

Again, I thought the removal of the source file was handled properly by the DiskWrapper here, but I guess not. I'll have to add the manual removal. I didn't even think about the FileManager doing this too since I don't use it.

[jneilliii]

Just pushed another commit that also removes the gcode file from the plugin's data folder.