Nice job with including progress bar support when a network request goes out. You might want to check out third-party progress bars in the future with an improved look and feel.
Good to see you used the RecyclerView ItemClickSupport item click decorator approach to handle clicks to the items.
Glad to see you used a date-time picker. To make sure the picker looks better on older devices (pre-Lollipop), you can check out third-party libraries for improved backwards compatibility.
In the future, you might want to take a closer look at Retrofit for networking as this library is quite popular and used in many apps.
Good to see you got sharing working using the ShareActionProvider system. Keep in mind that this is simply leveraging the implicit intent system behind the scenes. Refer to this guide on implicit intents to see other common usages of them.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional app including persistence with SQLite and modular view re-use with Fragments.
jnermano
commented
6 years ago
:+1: nice work. Some notes after checking out the code:
Toolbarwithin your activities. Be sure to use check out how to collapse the Toolbar on scroll using theCoordinatorLayout.ItemClickSupportitem click decorator approach to handle clicks to the items.Good to see you got sharing working using the
ShareActionProvidersystem. Keep in mind that this is simply leveraging the implicit intent system behind the scenes. Refer to this guide on implicit intents to see other common usages of them.Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional app including persistence with SQLite and modular view re-use with Fragments.