search

jnessier / ReverseProxy-PlausibleAnalytics

Reverse proxy for Plausible Analytics, written in PHP for Shared Hostings on Apache.
MIT License
30 stars 6 forks source link

Add server-side cache #8

Closed julienmru closed 9 months ago

julienmru commented 1 year ago

Hello : )

I'm thinking of adding server side-cache (for cacheable components), do you think this is something which could prove useful or it's a waste of my time?

Thanks.

jnessier commented 1 year ago

Thx for your input. I will check your pull request as soon as I have time.

jnessier commented 1 year ago

Released Version 1.3.0. Please try it out and give a final feedback if everything is fine.

julienmru commented 1 year ago

Everything seems to be working perfectly on my end. Thanks!

However, this issue was for a server-side cache rather and a client-side cache which is already handled by my pull request. The idea is to prevent the reverse proxy to pull again the scripts from Plausible if Plausible allows to cache them (which is the case at the moment).

jnessier commented 1 year ago

Oh I'm sorry, I mixed your stuff up.

I built the reverse proxy with one mission: To hide the origin of the plausible stats. Personally I don't want to much logic in the proxy functionality to keep the maintenance and support level low. And with the your implemented support for client side cache, I don't see a large benefit to implement a server side cache too.

Is it ok for you?