search

jnhwkim / cbp

Multimodal Compact Bilinear Pooling for Torch7
Other
68 stars 23 forks source link

supports different dimension #3

Closed chingyaoc closed 8 years ago

chingyaoc commented 8 years ago

Hi, I modified some codes in CompactBilinearPooling.lua to make it support different dimension of two input vectors. Please check it!

jnhwkim commented 8 years ago

@JamesChuanggg Thanks! However, this code is maintained using test cases. Can you update cbptest.testPsi() in test/test.lua resulting an error. This test case checks the expectation of psi functions.

chingyaoc commented 8 years ago

Thanks for reply. I'm wondering why using "dot" to measure the error since we can not computer dot for two vector with different length.

jnhwkim commented 8 years ago

@JamesChuanggg You're right. It's for the compatibility check. Multimodal version is extended from unimodal version. In Section 3.2 of Gao et al. (2015), there is a property of E[<Ψ(x, h, s),Ψ(y,h, s)>] =<x, y> about the phi(Ψ) function. The test case makes sure this property.

Could you update the test case having the same-sized vectors to check the phi function as before?

chingyaoc commented 8 years ago

I've modified function psi() in CompactBilinearPooling.lua to make it support same homogeneous case and `test/test.lua return no error.

jnhwkim commented 8 years ago

@JamesChuanggg Thanks!