search

jni / affinder

Quickly find the affine matrix mapping one image to another using manual correspondence points annotation
https://jni.github.io/affinder/
BSD 3-Clause "New" or "Revised" License
18 stars 13 forks source link

Optionally delete points layers after finishing alignment #88

Closed andreasmarnold closed 11 months ago

andreasmarnold commented 11 months ago

Addresses issue #9

I did not write any tests for this since I didn't really know how (close_affinder also doesn't seem to get tested)

Also, this option has the same issue as described in #29

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (927b50f) 90.66% compared to head (4156cb1) 93.52%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================== + Coverage 90.66% 93.52% +2.86% ========================================== Files 7 7 Lines 257 278 +21 ========================================== + Hits 233 260 +27 + Misses 24 18 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jni commented 11 months ago

Thanks for the update @andreasmarnold! Let me know if you want me to wrap up this PR myself.

andreasmarnold commented 11 months ago

Hi @jni, It would be great if you could have a look at implementing functools as you suggested. I've not worked with it before and don't really have lots of free time to familiarize myself with it before Christmas. Probably much more efficient if you do it ....

Thx!

jni commented 11 months ago

Whoop whoop! Actually the functools.partial method was a bit trickier than I expected so I'm glad I didn't leave you to finish it on your own. 😂 Remember to git switch main and git pull upstream main to get up to date with this change! 😊

andreasmarnold commented 11 months ago

Haha, yeah I also felt it's not quite as easy when I had a look... Thanks for your help!

Am Di., 12. Dez. 2023 um 01:33 Uhr schrieb Juan Nunez-Iglesias < @.***>:

Whoop whoop! Actually the functools.partial method was a bit trickier than I expected so I'm glad I didn't leave you to finish it on your own. 😂 Remember to git switch main and git pull upstream main to get up to date with this change! 😊

— Reply to this email directly, view it on GitHub https://github.com/jni/affinder/pull/88#issuecomment-1851383532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCPUYP2QQXJKJLGHNRPTXDYI73B7AVCNFSM6AAAAAA76CDLQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGM4DGNJTGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Andreas M. Arnold, PhD Postdoctoral Fellow Biochemistry and Biophysics Center NHLBI, NIH 50 South Drive, Building 50 RM 3310 Bethesda, MD 20892, USA

USA mobile: +1 202 989 9004 AUT mobile: +43 676 6131728 @.*** www.linkedin.com/in/andreasmarnold