Closed jamesyan-git closed 2 years ago
:heart: lovely! :blush:
Merging #29 (21f8597) into main (c582d5b) will increase coverage by
8.33%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 69.34% 77.68% +8.33%
==========================================
Files 13 14 +1
Lines 535 578 +43
==========================================
+ Hits 371 449 +78
+ Misses 164 129 -35
Impacted Files | Coverage Δ | |
---|---|---|
src/zarpaint/_tests/test_watershed.py | 100.00% <100.00%> (ø) |
|
src/zarpaint/_watershed.py | 100.00% <100.00%> (+75.67%) |
:arrow_up: |
src/zarpaint/_points_util.py | 81.81% <0.00%> (+63.63%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c582d5b...21f8597. Read the comment docs.
@jni Hey Juan, I have some tests for the new watershed split
Good, the current behaviour annoyed me. With the distance transform it should be much nicer!
Woot woot! Thank you @jamesyan-git for the great implementation and great tests (!), and @GenevieveBuckley for the prod! :blush:
Prior watershed split implementation did not work for 2D as it assumed 3D for connectivity. This has been changed to use a distance transform that works for nD. Tests to follow shortly