search

jni / zarpaint

Paint segmentations directly to on-disk/remote zarr arrays
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

BUG: function correct_labels does not exist in the codebase, console entry point broken #31

Open GenevieveBuckley opened 2 years ago

GenevieveBuckley commented 2 years ago

The console entry point refers to zarpaint._main:main, but this produces an error. You cannot run the main function here because it tries to execute a function correct_labels that doesn't exist anywhere in the codebase. (I think it's been partially refactored, causing this issue).

GenevieveBuckley commented 2 years ago

Perhaps it should be create_labels instead?

jamesyan-git commented 2 years ago

Hi @GenevieveBuckley ,

I had a look at the history, and based on these two commits , I think the CLI usage is deprecated and been replaced with the command listed here .

Looks like the rest of the functionality in LabelCorrector has been split up into the different widgets of the plugin? @jni I think we should be removing _main.py and LabelCorrector entirely but can you please confirm. If there is functionality in there that we want to keep please let me know.

GenevieveBuckley commented 2 years ago

Thanks for looking into it!

jni commented 2 years ago

I can confirm your interpretation @jamesyan-git! Thanks for looking into it! 😊