jni / zarpaint

Paint segmentations directly to on-disk/remote zarr arrays
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

Remove warnings related to events #35

Closed GenevieveBuckley closed 2 years ago

GenevieveBuckley commented 2 years ago

Closes https://github.com/jni/zarpaint/issues/34

GenevieveBuckley commented 2 years ago

Note: There are several other locations where zarpaint uses the .value attribute (similar to this one). Perhaps they all need to be changed?

I can't find information about what I believe was a recent change in how PyQt handles events, that would help me better understand if I should do it for all of them. Unfortunately the warnings aren't obvious when you run the test suite, so the other alternative is to click through more workflows with zarpaint and see what pops up in the terminal.

jni commented 2 years ago

Hmm, looks like we need to change our test suite to use py3.8+.

Re events, no, I don't think those need to be changed yet. I think we want to eventually move to psygnal events, but in napari we are still using VisPy. The reason we were seeing the warning is that magicgui moved to the new system — it moves faster than napari itself.

Lemme make a PR with the test suite changes, then we can merge that in here.

Thanks @GenevieveBuckley!

codecov-commenter commented 2 years ago

Codecov Report

Merging #35 (2b5ec8b) into main (9514d25) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   77.72%   77.85%   +0.13%     
==========================================
  Files          14       14              
  Lines         579      578       -1     
==========================================
  Hits          450      450              
+ Misses        129      128       -1     
Impacted Files Coverage Δ
src/zarpaint/_zarpaint.py 42.20% <100.00%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9514d25...2b5ec8b. Read the comment docs.

GenevieveBuckley commented 2 years ago

Ok cool.

One more thing to note: the directory widget button in zarpaint for the label filename isn't working for me anymore. It's flashing up with a GUI, then disappearing super quick. I can open the file widget GUI from the main napari image open file menu.

I see a lot of these messages in the terminal:

2022-07-15 15:59:08.694 python[75489:6782011] WARNING: <NSSavePanel: 0x16a114e00> -[NSSavePanel(exportedInterface) requestAppEnabledStateForItems:replyBlock:] no longer has a delegate to respond to shouldEnableURL

I haven't submitted an issue because:

Just wanted to mention it, even if we're not taking any action now, just in case this or something similar pops up in future.