Closed GenevieveBuckley closed 2 years ago
Note: There are several other locations where zarpaint uses the .value
attribute (similar to this one). Perhaps they all need to be changed?
_dims_chooser.py
line 79 set_dims_order(dims, event.value)
_dims_chooser.py
line 83 move_indices(axes_list, event.value)
_dims_chooser.py
line 108 set_dims_order(dims, event.value)
_dims_chooser.py
line 112 move_indices(axes_list, event.value)
_zarpaint.py
line 27 widget.labels_file.value = labels_path
I can't find information about what I believe was a recent change in how PyQt handles events, that would help me better understand if I should do it for all of them. Unfortunately the warnings aren't obvious when you run the test suite, so the other alternative is to click through more workflows with zarpaint and see what pops up in the terminal.
Hmm, looks like we need to change our test suite to use py3.8+.
Re events, no, I don't think those need to be changed yet. I think we want to eventually move to psygnal events, but in napari we are still using VisPy. The reason we were seeing the warning is that magicgui moved to the new system — it moves faster than napari itself.
Lemme make a PR with the test suite changes, then we can merge that in here.
Thanks @GenevieveBuckley!
Merging #35 (2b5ec8b) into main (9514d25) will increase coverage by
0.13%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 77.72% 77.85% +0.13%
==========================================
Files 14 14
Lines 579 578 -1
==========================================
Hits 450 450
+ Misses 129 128 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/zarpaint/_zarpaint.py | 42.20% <100.00%> (+0.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9514d25...2b5ec8b. Read the comment docs.
Ok cool.
One more thing to note: the directory widget button in zarpaint for the label filename isn't working for me anymore. It's flashing up with a GUI, then disappearing super quick. I can open the file widget GUI from the main napari image open file menu.
I see a lot of these messages in the terminal:
2022-07-15 15:59:08.694 python[75489:6782011] WARNING: <NSSavePanel: 0x16a114e00> -[NSSavePanel(exportedInterface) requestAppEnabledStateForItems:replyBlock:] no longer has a delegate to respond to shouldEnableURL
I haven't submitted an issue because:
conda install pyqt -c andfoy
on python 3.9 and then fight furiously to avoid having that overwritten when you install napari/magicgui/etc.Just wanted to mention it, even if we're not taking any action now, just in case this or something similar pops up in future.
Closes https://github.com/jni/zarpaint/issues/34