search

jnicklas / turnip

Gherkin extension for RSpec
974 stars 112 forks source link

Send step notifications and add metadata for RSpec reporter #245

Closed aramvisser closed 2 years ago

aramvisser commented 2 years ago

I made a Turnip extension to the RSpec documentation formatter to show each step on it's own line. To do that I needed to extend Turnip to send some custom step notifications to the RSpec formatter and add all the steps in a scenario as example metadata.

These might be helpful for other people, so I would like to merge those patches back in. There are 2 commits.

The first commit is for sending step notifications to the RSpec reporter and has tests. The second commit adds all the steps as metadata to the scenario. This is straightforward, but I didn't find a good way to test that, so has no tests.

These patches including the extensions to the RSpec documentation formatter were sent in a previous pull request. While the extensions to the formatter were not wanted then, I hope these extensions to Turnip are still okay.

leoc commented 2 years ago

Hi @aramvisser

Thanks a lot for your pull request! I was a little to quick to merge here. Could you rebase on master and have a look on the failing tests. I'd be happy to merge your changes a quickly as I can in order to get this beautiful documentation formatter working :+1: