search

jniemann66 / ReSampler

High quality command-line audio sample rate converter
GNU Lesser General Public License v2.1
160 stars 26 forks source link

various fixes for android #22

Closed mgood7123 closed 4 years ago

mgood7123 commented 4 years ago

could you please merge this, or create an Android branch and allow me write access to it

jniemann66 commented 4 years ago

It looks ok, except for I don't really agree with indenting the contents of the namespaces. It's usually standard c++ practice to not indent them - Probably because namespaces are intended to be used for preventing name clashes, and not as a scoping mechanism.

mgood7123 commented 4 years ago

It looks ok, except for I don't really agree with indenting the contents of the namespaces. It's usually standard c++ practice to not indent them - Probably because namespaces are intended to be used for preventing name clashes, and not as a scoping mechanism.

oh ok

mgood7123 commented 4 years ago

reverted namespace indentation