search

jnimmo / hass-dmx

Home Assistant DMX over IP Integration
MIT License
107 stars 47 forks source link

Abort transition when a new command is sent, allow transitions to be float and set add ability for default off #28

Closed chaptergy closed 3 years ago

chaptergy commented 4 years ago

When transitioning a device, a new command should abort this previous transition to avoid switching back to the transitioning state. Transitions should also be float to allow for transitions less than 1 second. Home Assistant supports transitions < 1, and so should the config. Currently the devices can only be set to default to value 0, which sets the brightness to 0, but the state of the entity is still on. With this new default_off config field it is set to the off state, and can be then switched on without the brightness being 0.

chaptergy commented 4 years ago

Does default level 0 not have them off by default?

Technically yes, the lamps are off, however in Home Assistant the state of the device is on, just their brightness is set to 0.

cHynInTeam commented 4 years ago

Hi! I checked these changes - it's working perfect for me. It fixes Issue #6 (in my case led blinks while two parallel trasitions running) and default_off are definitely useful - now you don't need to specify brightness on every turn_on/toggle operations, like before.

cHynInTeam commented 4 years ago

@jnimmo, merge this request, please...