search

jninalex / Yelp

0 stars 0 forks source link

[Intro to iOS] Assignment 3 - Review my app #1

Open jninalex opened 8 years ago

jninalex commented 8 years ago

I've completed assignment quickstart videos one and two. Please review. /cc @codepathreview

minhchau273 commented 8 years ago

Hi Jeanne, Please update time spent in README. Thanks.

minhchau273 commented 8 years ago

:+1: Nice work! This primary challenge of this homework was to learn how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.

Some small comments:

We have a detailed Project 3 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

chieger commented 8 years ago

Hi Jeanne,

We need you to make the updates that Chau mentioned in the above comment in order to give you credit for this assignment.

Please make these updates by the end of today as it is already 3 days past the deadline.

Thanks, Charlie

jninalex commented 8 years ago

Good evening Charlie,

As I was trying to making the updates for the app, something went terribly wrong with my code as I was merging it to my GitHub repository. I've been trying to figure it out all afternoon but, unfortunately, I think I've just made it worse. I even asked for help from my student leaders. I was wondering if I could get an extra day because I really don't think I can allot any more time for the app. I still have to continue studying for my Multivariate Calculus test tomorrow morning. I will continue working on it right after my test.

From the instructions: "Search bar http://guides.codepath.com/ios/Search-Bar-Guide#search-bar-in-navigation-view should be in the navigation bar (doesn't have to expand to show location like the real Yelp app does)." I thought that it meant that we only had to show a search bar but it didn't have to work. It's my fault for not double-checking with the student leaders.

I am terribly sorry for this and I hope you understand.

Best, Jeanne Nina Laurel

On Wed, Feb 17, 2016 at 5:23 PM, Charlie Hieger notifications@github.com wrote:

Hi Jeanne,

We need you to make the updates that Chau mentioned in the above comment in order to give you credit for this assignment.

Please make these updates by the end of today as it is already 3 days past the deadline.

Thanks, Charlie

— Reply to this email directly or view it on GitHub https://github.com/jninalex/Yelp/issues/1#issuecomment-185434293.

Jeanne Nina Laurel Vice President, Asian Pacific American Coalition Fordham University '18 Computer Science Major, Mathematics & New Media and Digital Design Minor www.jeanneninalaurel.me

chieger commented 8 years ago

Hi Jeanne, Hope your Calc test went well! What is the ETA of your completed project?

Charlie

jninalex commented 8 years ago

Hello Charlie,

It still keeps giving me the error: "Line 51: StartTag: invalid element name"

[image: Inline image 2][image: Inline image 3][image: Inline image 1]

One of my student leaders, Elana, has been working with me on this last night. She said that the code works well on her laptop but it doesn't on mine. She said that we'll work it again tonight if I still haven't figured it out. Someone said that my storyboard file seems to have been edited as a document? (I'm not entirely sure what that means -- I'm currently waiting on responses from other people on the channel).

My apologies, Jeanne Nina Laurel

On Thu, Feb 18, 2016 at 2:59 PM, Charlie Hieger notifications@github.com wrote:

Hi Jeanne, Hope your Calc test went well! What is the ETA of your completed project?

Charlie

— Reply to this email directly or view it on GitHub https://github.com/jninalex/Yelp/issues/1#issuecomment-185891148.

Jeanne Nina Laurel Vice President, Asian Pacific American Coalition Fordham University '18 Computer Science Major, Mathematics & New Media and Digital Design Minor www.jeanneninalaurel.me

chieger commented 8 years ago

Hi Jeanne,

You basically had a bunch of git merge conflicts. I sent you instructions on how to fix those in Slack. Once I removed the conflicts, I was able to see your project was complete...so YAY!!! 😀

:+1: Nice work! This primary challenge of this homework was to learn how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.

We have a detailed Project 3 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

jninalex commented 8 years ago

Hello Charlie,

I was actually able to fix everything yesterday and pushed it to a new repository, Yelp-App. Thank you so much for your help and for being very understanding.

Best, Jeanne Nina Laurel