jnjcc / cl-qrencode

QR code 2005 encoder in Common Lisp
GNU General Public License v2.0
32 stars 8 forks source link

What about "you serious about this?!"? #11

Closed phmarek closed 5 years ago

phmarek commented 5 years ago

Trying to encode some ASCII string I get the error "you serious about this?!" in CL-QRENCODE::TERMINATOR.

Why do I get that error?

jnjcc commented 5 years ago

Are you encoding some long string? Seems like it exceeds the data word capacity.

BTW, your last pull request #10 failed some test case, I haven't had time to figure out why, sorry.

phmarek commented 5 years ago

The code is

(CL-QRENCODE:ENCODE-SYMBOL 
  "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/xxxxx?id=8C0F677B08DF2E6897015FF5&code=abcdefgh" 
  :VERSION 1 
  :LEVEL :LEVEL-L 
  :MODE NIL)
jnjcc commented 5 years ago

This is a bug. Fixed in 0de2d8a3877b499a9a0bbb0a9e1247056ae4311e.

Thanks!

phmarek commented 5 years ago

Thanks a lot!

I've pushed another fix - now the compile errors in test/utils.lisp are gone, only VALIDATE-MASK0-7 has an unexpected result: Expected (0 1 0) but saw (1 0 0).

jnjcc commented 5 years ago

TBH, I don't quite remember the meaning of this test case either, :-(

Might have to dig into it some later time when I'm free.

Thanks again.