search

jnko / SimpleDatabaseBackup

SimpleDatabseBackup is a KeePass plugin which was created for simpleness. There is no setup, no GUI and no configuration no dependencies. Just copy over the plugin into KeePess plugin folder and you are done.
49 stars 5 forks source link

Not working #1

Closed greatvc closed 7 years ago

greatvc commented 7 years ago

Hi, i copied the simpledatabase backup on the program folder, i can see in in the plugins of keepass (latest version), but i just saved my database and i see no backup file on the database folder. Am saving on the google drive using the local path C:\Users\username\Google Drive\Personal\KeepPass Database\ but i tested it with another database on the local path and again no backups

Am i doing something wrong ?

thank you

jnko commented 7 years ago

Am 18.10.2016 um 19:05 schrieb Vassilis:

Hi, i copied the simpledatabase backup on the program folder, i can see in in the plugins of keepass (latest version), but i just saved my database and i see no backup file on the database folder. Am i doing something wrong ?

thank you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jnko/SimpleDatabaseBackup/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ACI0P0R5QQ4fPtcHuZO5YrkK_fTdkdDNks5q1PxygaJpZM4KaDHD.

Give me a minute... or two. I guess I just made an logical mistake on how I handle the FileSaved event within the Database.Modified property. It does not really makes sense to test for the Database.Modified property inside the FileSaved event. As the name suggests in the FileSaved event the file actually has been saved so the Databse.Modified property must always be false.

Well shame on me that should not happen and I was too busy to verify this deeply enough. I will release a fix within the next few hours.

Thanks for reporting.

jnko commented 7 years ago

Ok, I fixed this bug and it is working now as expected. I replaced the the FileSaved event with FileSaving which is being fired before the database is saved. This way the DB.Modified test will work.

Please update the plugin to version 1.0.4 It should pop up the usual KeePass update notification on next KeePass start or just click Help->Check for updates to manually force.

I'm closing this issue and again thanks for reporting.

greatvc commented 7 years ago

wow that was fast! yes i can confirm that it works now, many thanks!