jnobre / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

Stub overlap issue when top and left endpoints are connected. #307

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi,

When you try to connect 4(top) to 3(Left) in
http://www.jsplumb.org/jquery/flowchartConnectorsDemo.html

and then move 3 to top, you will see something like the attached image.

Original issue reported on code.google.com by fahadnab...@gmail.com on 7 Jan 2013 at 8:16

GoogleCodeExporter commented 8 years ago
Here is the png format

Original comment by fahadnab...@gmail.com on 7 Jan 2013 at 8:17

Attachments:

GoogleCodeExporter commented 8 years ago
I have fixed this in 1.4.0.  should be releasing 1.4.0 soon.

Original comment by simon.po...@gmail.com on 7 Jan 2013 at 8:21

GoogleCodeExporter commented 8 years ago
Wow cool, when will it be released? Can I get the current fixed source from 
github repo?

Fahad

Original comment by fahadnab...@gmail.com on 7 Jan 2013 at 8:53

GoogleCodeExporter commented 8 years ago
yes, it's checked in to github.

i havent got a final date yet for when i will release 1.4.0.  soon though.

Original comment by simon.po...@gmail.com on 7 Jan 2013 at 8:54

GoogleCodeExporter commented 8 years ago
Thanks I will get it from there, you rock Simon :)

Original comment by fahadnab...@gmail.com on 7 Jan 2013 at 9:09

GoogleCodeExporter commented 8 years ago
no problem.  do you know how to build jsPlumb?  instructions are here:

https://github.com/sporritt/jsPlumb/wiki/Build

Original comment by simon.po...@gmail.com on 7 Jan 2013 at 9:13

GoogleCodeExporter commented 8 years ago
Yes you already mentioned the instructions link on how to build the source, 
cheers

Original comment by fahadnab...@gmail.com on 7 Jan 2013 at 9:22

GoogleCodeExporter commented 8 years ago
Simon, I just build 1.4.0 and the problem is still there, it is only when you 
drag the top endpoint of one to right endpoint of other and then move the 
second one towards top.

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 10:55

GoogleCodeExporter commented 8 years ago
is this when the two elements are quite close together in the X direction?

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 11:00

GoogleCodeExporter commented 8 years ago
(can you provide me with a screenshot of what you mean now)

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 11:09

GoogleCodeExporter commented 8 years ago
No the problem is illustrated in the following two images. One is with correct 
position and the other is with the issue.

The problem occurs when you connect top endpoint to the right endpoint and then 
make the right side end point almost adjacent to to the topside endpoint. That 
is the issue with y-axis positioning of draggable components

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 11:28

Attachments:

GoogleCodeExporter commented 8 years ago
let me know if you are not able to reproduce and I will share my screen on 
join.me to show you what the issue is

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 11:32

GoogleCodeExporter commented 8 years ago
um...this might sound odd, but are you sure that's 1.4.0?  i would expect to 
see rounded corners on those connectors. the attached file shows how it looks 
for me, out of the box with 1.4.0.

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 7:22

Attachments:

GoogleCodeExporter commented 8 years ago
really strange... I used ant -Dversion=1.4.0-RC1 -Dforce=true to get 1.4.0 
isn't it all to get 1.4.0?

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 7:53

GoogleCodeExporter commented 8 years ago
yep, that's how you build it. what browser is this?

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 7:59

GoogleCodeExporter commented 8 years ago
it is chrome, both chrome and firefox show same results. I am using MAC OSX.

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:06

GoogleCodeExporter commented 8 years ago
do we have to change anything in build.xml to get the latest version?

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:10

GoogleCodeExporter commented 8 years ago
or may be you can attach jquery.jsPlumb-1.4.0-all.js here and I can verify if 
it is the checkout issue or browser issue

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:11

GoogleCodeExporter commented 8 years ago
nothing has to be changed in build.xml.  what is that page you are looking at?

do you see the same behaviour here:

http://morrisonpitt.com/jsPlumbTest/demo/jquery/flowchartConnectorsDemo.html

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 8:12

GoogleCodeExporter commented 8 years ago
Yes I was looking at the same page but the link you showed shows something 
different. I am uploading my version, I will send you a link shortly to see how 
it comes up for me

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:18

GoogleCodeExporter commented 8 years ago
the link i shared is what is in 1.4.0. 

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 8:19

GoogleCodeExporter commented 8 years ago
Here is what I see with 1.4.0

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:20

GoogleCodeExporter commented 8 years ago
http://76.163.202.83/demo/ken/jsplumb/1.4/demo/jquery/flowchartConnectorsDemo.ht
ml

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:20

GoogleCodeExporter commented 8 years ago
you have updated recently havent you.  

i noticed the demo code

http://76.163.202.83/demo/ken/jsplumb/1.4/demo/js/flowchartConnectorsDemo.js

is different from what is on github, for example.

https://github.com/sporritt/jsPlumb/blob/master/demo/js/flowchartConnectorsDemo.
js

i know this is fixed in 1.4.0.  i don't have a whole lot more time to bounce 
this around.

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 8:35

GoogleCodeExporter commented 8 years ago
Yes I recently updates, anyways I will get the codes from your demo link for 
now until it is released, however the similar issue is there on your 1.4.0's 
demo, if you close the connectors horizontally you will notice the lines 
overlapping each other. Once again thanks for your time.

Original comment by fahadnab...@gmail.com on 8 Jan 2013 at 8:45

GoogleCodeExporter commented 8 years ago
yeah it's a similar issue but not exactly the same: the lines overlap when the 
nodes are closer together horizontally than the value of the "stub" parameter.  
this won't change.  

Original comment by simon.po...@gmail.com on 8 Jan 2013 at 8:50

GoogleCodeExporter commented 8 years ago
Hi I have the same issue. kindly help me for this. I am attaching an image 
which explains my issue.

Original comment by asadmehm...@gmail.com on 6 Aug 2014 at 6:10

Attachments: