search

jnoellsch / ektron-fluentapi

Adds a fluent API over the existing Ektron Framework API to increase code readability and discoverability
MIT License
2 stars 0 forks source link

Filter class refactor? #6

Closed jnoellsch closed 9 years ago

jnoellsch commented 9 years ago

Should the Filter class be refactored to take on the field property as another generic type?

jnoellsch commented 9 years ago

@ssartell Can you take a peek at this and tell me what you think?

ssartell commented 9 years ago

I think you'll need to show me in person. Are you trying to get rid of the object parameter? It looks like that's how Ektron takes in filter values anyways.

ssartell commented 9 years ago

Just for future reference, this can't be done. ContentCollectionCriteria doesn't inherit from Criteria and implements it's own version of AddFilter instead. Therefore AddFilter can't be called polymorphically. Maybe there's some way around it where we handle ContentCollectionProperty differently, but it seems difficult at best.