better color for line highlighting

jnolis / synthwave85

A 80s style theme for RStudio v1.2+

MIT License

87 stars 25 forks source link

better color for line highlighting #4

Closed rgerecke closed 5 years ago

rgerecke commented 5 years ago

First of all, I'm obsessed, thank you for your Very Important Contribution.

If you have line highlighting enabled, the color is a muddy grey that doesn't fit well with the rest of the styling! Unsure what the JS style class is or what a better color would be. Screenshot below w/ the point of contention.

jnolis commented 5 years ago

Oh good catch, that's something I missed from the base theme. I'll check it out!

jnolis commented 5 years ago

Okay, I have the color looking better, can you tell me what you think of this? If you like it I'll launch it (I never use this feature so I can't tell if it's too bright or dark).

You can test it yourself by uninstalling the old version and running:

rstudioapi::addTheme("https://raw.githubusercontent.com/jnolis/synthwave85/active-line-issue/Synthwave85.rstheme", TRUE, TRUE, FALSE)

rgerecke commented 5 years ago

finally had a moment to check it out--perfect! thank youuuuu

jnolis commented 5 years ago

Closed via commit #f0305bbb !