Added ability to pass in raw image data

jnordberg / gif.js

JavaScript GIF encoding library

http://jnordberg.github.io/gif.js/

MIT License

4.76k stars 668 forks source link

Added ability to pass in raw image data #10

Closed hdragomir closed 11 years ago

hdragomir commented 11 years ago

This change allows addFrame(image, params) to receive an ImageData instance apart from the already existing canvas/image. It could probably be merged into the existing code a bit more as far as params merging is concerned; please advise.

jnordberg commented 11 years ago

Thanks, looks good. Left a couple of comments in the diff

hdragomir commented 11 years ago

Hey, I was just wondering if you got around to reviewing the new commit.

jnordberg commented 11 years ago

Hey, slipped my mind.. Looks ok, the frame.width assignment is still a bit weird but the whole size assignment in addFrame is bit of a hack anyways.

hdragomir commented 11 years ago

:thumbsup: