Closed hdragomir closed 11 years ago
Thanks, looks good. Left a couple of comments in the diff
Hey, I was just wondering if you got around to reviewing the new commit.
Hey, slipped my mind.. Looks ok, the frame.width assignment is still a bit weird but the whole size assignment in addFrame is bit of a hack anyways.
:thumbsup:
This change allows
addFrame(image, params)
to receive anImageData
instance apart from the already existing canvas/image. It could probably be merged into the existing code a bit more as far as params merging is concerned; please advise.