jnordberg / wintersmith

A flexible static site generator
http://wintersmith.io/
MIT License
3.5k stars 332 forks source link

Rename Jade to pug #308

Closed suriyaa closed 5 years ago

suriyaa commented 8 years ago

Hi @jnordberg, :smiley:

I edit the package.json file. :pencil:

Because of the npm error: "WARN deprecated jade@1.11.0: Jade has been renamed to pug, please install the latest version of pug instead of jade"

See

Yours, Suriyaa Kudo :octocat:

jnordberg commented 8 years ago

Hi, and thanks! Just had a look on npm and the only versions of pug are

     '0.0.0',
     '0.1.0',
     '2.0.0-alpha1',
     '2.0.0-alpha2',
     '2.0.0-alpha3'

Seems like this might be more than a rename..

suriyaa commented 8 years ago

I changed the version to 0.1.0.

It's better to use the stable version 0.1.0 instead of the alpha version:

'2.0.0-alpha1',
'2.0.0-alpha2',
'2.0.0-alpha3'
jnordberg commented 8 years ago

Agreed, but strange versions for just a name change, is there any documentation about it? Which version is equivalent to 1.11.0?

suriyaa commented 8 years ago

@jnordberg I found it here: https://github.com/pugjs/pug/issues/2184! :smiley:

timvandermeij commented 8 years ago

Is anything blocking this PR? It would be nice to get rid of this warning.

suriyaa commented 8 years ago

I'm also waiting for an answer from @jnordberg. :watch:

jnordberg commented 8 years ago

I'm waiting for a stable pug release, they are still in alpha afaik

There may be a pug@1.0.0 release aimed at being as compatible as possible with jade@1.x.y

ghost commented 8 years ago

Is this something that's still going to happen?

jnordberg commented 7 years ago

This will happen when they release a stable version

suriyaa commented 7 years ago

@jnordberg New version available: pug 1.11.0! Please merge. 😄

jnordberg commented 7 years ago

The 1.x version is not on npm and the developers have stated that they won't publish it under the pug name. https://github.com/pugjs/pug/issues/2352

Looks like we will have to live with the deprecation warning until pug 2 is stable

jnordberg commented 7 years ago

I've forked jade 1.11 to jade-legacy and will be maintaining that with security patches until the pug team releases something.

suriyaa commented 6 years ago

@jnordberg Any changes?

jnordberg commented 5 years ago

Added in 2.5.0!