search

jnordberg / wintersmith

A flexible static site generator
http://wintersmith.io/
MIT License
3.5k stars 332 forks source link

Beta release with Pug v2 support #324

Closed sirodoht closed 5 years ago

sirodoht commented 7 years ago

I want to use wintersmith but our app has switched to Pug v2. I searched and found #308 about using Pug instead of Jade.

Pug is now at beta11 and it is very stable despite the beta tag.

However, to ensure stability wintersmith could also publish a beta version, using Pug v2 beta. I'd be willing to create a PR.

What do you think?

jnordberg commented 7 years ago

Yeah sure, it has to be done at some point anyways :)

VaelynPhi commented 7 years ago

I just did a simple sed/jade/pug/g (well, with a few special renames, like JadeTemplate to PugTemplate) and everything seems to work just fine. Let me know and I'd be happy to submit the pull request. I branched first (pug-migrate) but could easily merge back to master and rebase if you prefer single commits.

Added after I thought about it: it probably needs testing; I am only using it on my blog so far, and that isn't even finished.

sirodoht commented 7 years ago

Yeah. Testing is where I got stuck too.

jnordberg commented 7 years ago

Create a PR with the changes and we can all test the same code

VaelynPhi commented 7 years ago

PR submitted; I was hoping to submit it as a new branch, but I'm not sure how to achieve that with Github, if possible at all. I'm mostly used to using git on the command line. Let me know if I can change anything that's helpful.

jnordberg commented 5 years ago

As of version 2.5.0 wintersmith uses pug, thanks @sirodoht @VaelynPhi @SuriyaaKudoIsc and @yusufhm!