search

jnorthr / socialauth

Automatically exported from code.google.com/p/socialauth
0 stars 0 forks source link

Oauth2 allow for popups in web authentication #260

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
When using facebook authentication, the user is presented with only the full 
browser page. By adding to Oauth2.java 
after line 88,
sb.append("&display=popup");        

Will allow for popup window. It would be nice to set on the provider a display 
param so that this can be tweaked.

Please add methods such as

setPopupAuthWindow(boolean)
isPopupAuthWindow()

and 
if ( bPopupAuthWindow){
sb.append("&display=popup");        
}

I have a patch for this for v4. If you would like

Original issue reported on code.google.com by al...@backpocket.com on 18 Mar 2013 at 8:17

GoogleCodeExporter commented 8 years ago 
yes, please provide the patch. We'll try to incorporate it.

Original comment by tarun.na...@3pillarglobal.com on 20 Mar 2013 at 11:01

GoogleCodeExporter commented 8 years ago 
is this popup functionality implemented? If not how can I incoporate in the 
exist java code? Please suggest me.

Original comment by oddz...@gmail.com on 22 Mar 2013 at 1:25

GoogleCodeExporter commented 8 years ago 
Hi oddz

This is not popup functionality. This change is only for showing authentication 
page in popup view mode. You have to write your own code to open authentication 
page in popup.

Where you are redirecting the url to show authentication page, that place you 
have to write a code to open this page in popup instead of redirecting it.

Original comment by tarun.na...@3pillarglobal.com on 9 Apr 2013 at 8:16