use ProbeError from pkg-config

jnqnfe / pulse-binding-rust

FFI and bindings for using PulseAudio from the Rust programming language.

Apache License 2.0

67 stars 20 forks source link

use ProbeError from pkg-config #46

Closed fredszaq closed 2 years ago

fredszaq commented 2 years ago

pkgconfig 0.3.23 changed added a new error in the case of a probe failure (see https://github.com/rust-lang/pkg-config-rs/pull/127)

This can cause previously building configuration (ie confs without the dev package installed for pulseaudio) to fail.

This change uses the new error from pkgconfig instead of the old one.

jnqnfe commented 2 years ago

Hi & thanks! I've manually merged a cherry-picked and tweaked copy of your commit - You'd missed applying the changes to the mainloop-glib crate and I felt that we should still catch and handle Failure as before alongside ProbeFailure rather than instead, and I decided to just go ahead and make the changes to your work myself this time rather than request them of you. :)

New versions of the sys crate are available on crates.io as of now.

fredszaq commented 2 years ago

Great! thank you!