jnr / jffi

Java Foreign Function Interface
Apache License 2.0
168 stars 78 forks source link

[Feature Request] Direct Mapping like JNA's? #156

Open Tianscar opened 8 months ago

Tianscar commented 8 months ago

I think it will be more convenient to use Java's built-in syntax, i.e. native method, to call native methods. "JNADirect" does this.

In order to do this with JFFI, I tried to create a Closure#Handle on the Java side (in the Closure object, using Invoker to call the native method) and then use NativeMethods#register to link the Closure#Handle's function pointer to the native method stub on the Java side.

But this is too slow, due to the whole process went through multiple calls back and forth between Java and native:

Java (downcall to native, method with `native` keyword)
 -> native (upcall to Java, ffi closure)
 -> Java (downcall to native, Java closure)
 -> native (performing `ffi_call`)
 -> the native method I wanna call

JNA do the entire process of creating the ffi_closure and performing ffi_call on the native side, which avoids multiple calls on the Java and native sides, ensures performance.

Could you consider adding this feature or adding some methods to a more efficient way implementing this feature?

Thanks in advance

headius commented 7 months ago

I would love to support this feature, but I'm not sure I understand it!

Do you know where JNA does this in their codebase? We should be able to copy the same logic but it sounds like it will require work on the native side (to do the entire ffi_closure logic within the generated native stub).

Tianscar commented 7 months ago

https://github.com/java-native-access/jna/blob/505fd9fb343181ad344e319c1b2f98f87322458e/native/dispatch.c#L3479 https://github.com/java-native-access/jna/blob/505fd9fb343181ad344e319c1b2f98f87322458e/native/dispatch.c#L1776