search

jnr / jnr-unixsocket

UNIX domain sockets (AF_UNIX) for Java
Apache License 2.0
278 stars 75 forks source link

Provide JPMS module name #61

Closed sbordet closed 5 years ago

sbordet commented 5 years ago

Would be great if a stable JPMS module name can be provided, as simply as adding Automatic-Module-Name to the manifest in the jar.

This will allow projects that are moving to proper JPMS modules to reference a stable JPMS name for jnr-unixsocket in their module-info.java.

I would suggest to not use com.github as prefix, but perhaps just org.jnr, but it's ultimately your choice.

Thanks!

sbordet commented 5 years ago

Also, jnr-unisocket has a split package with jnr-enxio: jnr.enxio.channels.

This makes impossible to use jnr-unixsocket as JPMS module, even adding the Automatic-Module-Name entry.

headius commented 5 years ago

Fixed along with #58.