fix: Build by moving from findbugs to spotbugs and removing Java 7 tests

jnr / jnr-unixsocket

UNIX domain sockets (AF_UNIX) for Java

Apache License 2.0

278 stars 75 forks source link

fix: Build by moving from findbugs to spotbugs and removing Java 7 tests #80

Closed rhuss closed 4 years ago

rhuss commented 4 years ago

Actually the Travis build on master is broken because of an issue with findbugs 3. Since findbugs is deprecated, its seems to be better to switch to spotbugs, the successor. The pom.xml has been updated accordingly and some low hanging fruits have been fixed.

However the test show some concurrency issue, which might be considered to be fixed.

The test for Java 7 has been switched off in Travis as (a) the build is broken (see one of the latest Travis logs) and (b) spotbugs requires Java 8+

rhuss commented 4 years ago

@headius The current CI build on master is broken, this PR tries to fix is by switching from findbugs to spotbugs (and fixing some safe lower hanging fruits). Also Java 7 build has been disabled as this is broken, too (for some other reasons).

headius commented 4 years ago

Ahh thank you. Yeah I think Java 7 is just not in Travis anymore. Might need to look into an alternative, or set up Github Actions (help wanted!).