search

jnraine / munkiserver

Visit https://github.com/munkiserver/munkiserver for active development — this repository is no longer maintained
85 stars 27 forks source link

https:// Missing When Downloading Client Prefs #139

Closed Ginja closed 12 years ago

Ginja commented 12 years ago

MunkiServer seems to drop the protocol in any URL key when downloading client prefs. For example below is a snippet of what is downloaded:

<key>ManifestURL</key>
<string>example.ad.domain.ca</string>
<key>SoftwareRepoURL</key>
<string>example.ad.domain.ca</string>

But it really should be:

<key>ManifestURL</key>
<string>https://example.ad.domain.ca</string>
<key>SoftwareRepoURL</key>
<string>https://example.ad.domain.ca</string>

I haven't tested to see if all URL keys get their protocol dropped but I am going to assume so.

jnraine commented 12 years ago

Hey Ginja, I took a look into this and whatever value you add to your config/settings.yaml file should be used. Are you experiencing a different behaviour?

--- 
:action_mailer: 
  :host: "https://example.ad.domain.ca"
Ginja commented 12 years ago

I'm actually unable to reproduce this issue. I believe the issue was that I was downloading client prefs from clients that were never set up properly. I just downloaded a couple of client prefs and they all now properly display the https:// protocol on all of the URL keys. Sorry for the false ticket.