jnraine / munkiserver

Visit https://github.com/munkiserver/munkiserver for active development — this repository is no longer maintained
85 stars 27 forks source link

Deprecated fix #141

Closed treydock closed 12 years ago

treydock commented 12 years ago

Updates the usage of 'add_to_base' which seems to have been deprecated in Rails-3+ (http://apidock.com/rails/ActiveRecord/Errors/add_to_base).

rickychilcott commented 12 years ago

This will fix the deprecated warning. Jordan, please pull.

Ricky Chilcott

On May 7, 2012, at 7:53 PM, treydockreply@reply.github.com wrote:

Updates the usage of 'add_to_base' which seems to have been deprecated in Rails-2.3.8 (http://apidock.com/rails/ActiveRecord/Errors/add_to_base).

You can merge this Pull Request by running:

git pull https://github.com/treydock/munkiserver deprecated_fix

Or you can view, comment on it, or merge it online at:

https://github.com/jnraine/munkiserver/pull/141

-- Commit Summary --

  • Update usage of record.errors.add_to_base to use record.errors[:base]
  • Fix missing append

-- File Changes --

M config/initializers/date_time_validator.rb (4) M config/initializers/unique_as_shortname_validator.rb (4)

-- Patch Links --

https://github.com/jnraine/munkiserver/pull/141.patch https://github.com/jnraine/munkiserver/pull/141.diff


Reply to this email directly or view it on GitHub: https://github.com/jnraine/munkiserver/pull/141

joraff commented 12 years ago

Trey, I like that you're still contributing to this even though you don't mac sys admin anymore :)