search

jnraine / munkiserver

Visit https://github.com/munkiserver/munkiserver for active development — this repository is no longer maintained
85 stars 27 forks source link

Dismiss missing manifests once resolved #174

Closed nzmacgeek closed 11 years ago

nzmacgeek commented 11 years ago

When an admin is told they have a missing manifest, they will obviously go some way to resolve that by adding the computer if necessary. Once resolved, the admin should have some way to mark the missing manifest as resolved (clicking a dismiss button or something) so that they are not made to look at it any more.

I propose an attribute dismissed on the MissingManifest model which is checked by the recent scope so that the results passed to the widget controller are accurate at the time of rendering?

jnraine commented 11 years ago

Sounds like a reasonable addition. Have an implementation in mind?

nzmacgeek commented 11 years ago

Working on a patch right now, in fact. Give me a day or two, and I'll get back to you with some concrete code.

My feeling is that there should just be a dismiss link right next to each entry, which calls some UJS to perform the change and refresh the widget. I need to look at the code first to see what's possible, because I admit, until now, I've only been an end user of your (totes awesome) code.

nzmacgeek commented 11 years ago

An example of the potential UI appearance of a missing manifest item:

Screen Shot 2013-04-18 at 1 33 55 PM

z1ggur4t commented 11 years ago

looks good. i'd use it!

nzmacgeek commented 11 years ago

@jnraine, @z1ggur4t, please see the work I have done on my fork of munkiserver. If you like the changes, I will create a pull request.

Being my first proper rails app contribution (most of my usual work is private), I'm not familiar with protocol regarding changes to db/schema.rb - you may need to let me know if I've done something wrong there...

jnraine commented 11 years ago

Just reviewed 88e4d95. Looks good!

One consideration is that missing manifests can be dismissed by anyone and will no longer appear for anyone else — it is not scoped by unit. This will likely be an issue but is worth keeping in mind.

Send a pull request!

z1ggur4t commented 11 years ago

ah ok. good point. i guess that's too difficult to add to permissions it being in the general dashboard page?

jnraine commented 11 years ago

Yeah, probably more work than it's worth at this point. If it becomes an issue we can address it at that time.

On Thursday, 18 April, 2013 at 3:39 PM, z1ggur4t wrote:

ah ok. good point. i guess that's too difficult to add to permissions it being in the general dashboard page?

— Reply to this email directly or view it on GitHub (https://github.com/jnraine/munkiserver/issues/174#issuecomment-16616686).

nzmacgeek commented 11 years ago

Thanks for that pull, @jnraine. Now, to get on to some documentation!