search

jnraine / munkiserver

Visit https://github.com/munkiserver/munkiserver for active development — this repository is no longer maintained
85 stars 27 forks source link

Add batch delete functionality to Packages and Computers #180

Closed bruienne closed 8 years ago

bruienne commented 11 years ago

Added batch delete functionality to Packages and Computers. An additional 'Delete' button appears in the 'Edit Selection' form. After deletion the Packages or Computers main index is reloaded.

bruienne commented 11 years ago

Realizing this is very similar to pull request #144.

jnraine commented 11 years ago

@bruienne looks like you're right. That PR was never fully reviewed, though it looks like you had a look at it. Since you are most familiar with both PRs, which do you find to be most suited to be merged?

bruienne commented 11 years ago

Considering my changes are much more rudimentary than those in #144 I would vote for that one to be merged. I completely forgot another PR was open already (even though I commented and tested back then), but at least I got a chance to tinker with the code and have others look at it.

jnraine commented 11 years ago

Sounds good. Because of it's age, it's not merge-able without some conflict resolution. Can you merge @treydock's commits with master and submit another PR for it? I'll pull it in once it is ready.

Thanks!

Andware commented 10 years ago

Hello

I am also missing batch delete function on munki server.

Nothing has happened for the last six months, and I want to know if I have to integrate it myself?

Best regards Andreas Mühlemann

rickychilcott commented 10 years ago

Hi @Andware, do you know if this merges ok and whether it works properly? Also look at @treydock's PR from a while ago and see if it still works.

rickychilcott commented 8 years ago

This will finally be in after we merge https://github.com/munkiserver/munkiserver/pull/13

Thanks for your ideas and contributions several years ago!