Fixed icon scraping - Githubissues

jnraine / munkiserver

Visit https://github.com/munkiserver/munkiserver for active development — this repository is no longer maintained

85 stars 27 forks source link

Fixed icon scraping #185

Closed Ginja closed 11 years ago

Ginja commented 11 years ago

Macupdate is now redirecting all https://macupdate.com requests to https://www.macupdate.com
Added a regular expression substitution on the url_string to fix

coveralls commented 11 years ago

Coverage increased (+0%) when pulling 1e35c8cbeb5c83dec09e466cba730802b6655d4d on Ginja:master into e60a69568fbf9c5073e267078adda19e79c0a4fc on jnraine:master.

Ginja commented 11 years ago

It looks like I should have synced my repo with the upstream master branch before doing this commit. Didn't realize TravisCI would use my repository spec tests! I just pulled the latest commits in and everything passed, but I also see that my regular expression was not successfully catching/replacing in all cases. I'll push again to my master branch soon which should resolve everything.

I like TravisCI!

Ginja commented 11 years ago

Realized the scrape_icon method has already been re-worked, thus making my change unnecessary. Closing pull request.