search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

build: Fix building with Inkscape 1.0 #113

Closed chewi closed 3 years ago

chewi commented 3 years ago

This wasn't matching the >1.0.0 version check.

jnsh commented 3 years ago

Oops. Nicely spotted, thank you!

Did this cause packaging issues for gentoo?

chewi commented 3 years ago

It wasn't a big deal as Gentoo has already dropped 1.0 but I hadn't updated yet so I did notice.

Well done for doing this migration. Having done much of the Autotools work, I know it couldn't have been easy. Meson is certainly nice but I imagine you had to make use of features that few people are familiar with.

It worked out well for Gentoo. It took a little time to figure out how to support the pre-rendered build for the end result was tidy.

There's just one more question. I guess you're aware that you didn't add optipng to the Meson build? I only realised when I saw that my pre-rendered tarball was about twice as large as before. Was there a reason for this?

jnsh commented 3 years ago

I suppose no build system is particularly well designed for this kind of project, and I had to use lot of custom targets and install scripts. Then there was the additional difficulty from not being able to restructure the source files, in order to keep the Autotools build still working. There are a few compromises and sub-optimal solutions that had to be made, but everything can be improved later.

I'm quite unfamiliar with Autotools myself, so the switch to Meson should make it easier for me to maintain and implement new features.

The optipng support turned out to be quite tricky to implement, so I decided to drop that for now, but the plan is to add PNG optimization back once I get some other major work out the way. I should have mentioned this on the release notes though, to avoid confusion.

Happy to hear you figured out a solution for the pre-rendered PNGs, as I wasn't sure if that would be possible at all with Meson. In the future I'm hoping to have pre-generated PNG and CSS files in the release tarball, similar to what gnome-shell did here.