For GTK2, building just the dark variant fails if the expected light variant assets are not also built.

[tony-traylen]

For GTK2, building just the dark variant fails if the expected light variant assets are not also built. Reason: the dark and darker variants use both 'light_menubar_toolbar_assets' and 'dark_menubar_toolbar_assets'. Fix: always build the light assets.

[jnsh]

Thank you. Nicely spotted and the fix should be correct.

Could you just improve the commit message a bit, by adding a separate subject line at the beginning, e.g. build: Always render light assets, and a full URL to this pull request at the end (as requested in HACKING.md).

[tony-traylen]

Hey jnsh, thanks for the hint; my first ever PR. An amended commit message has been pushed - hopefully in an appropriate manner.

[jnsh]

Looks like I made a mistake on my suggestion for the first message line. That should have been build: Always render light GTK2 assets, since this only affects GTK2. Would you mind amending this one more time? Sorry about the hassle :/

Otherwise this looks perfect. Thank you!

Generally it's recommended to always have the first line as a separate title/short summary, as that works best for many git commands and tools. Some projects may also have special wishes for the commit messages (such as mentioning the relevant bug reports and pull requests, etc.). I recommend this post if you're interested in further reading about good commit messages :)

[tony-traylen]

Cheers for the advice and reference on best practice!

[jnsh]

Merged. Thanks again!