search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

Try to fix build with samurai #123

Closed ghost closed 3 years ago

ghost commented 3 years ago

There appears to be build order bug and the build fails with

samu: job failed: /usr/local/bin/glib-compile-resources --sourcedir=common/gtk-3.0 --target=common/gtk-3.0/gtk-lighter.gresource common/gtk-3.0/gtk-lighter.gresource.xml common/gtk-3.0/gtk-lighter.gresource.xml: Failed to locate checkbox-checked.png

It seems that dependencies on some assets are not properly specified.

Samurai is a Ninja-compatible build tool [0]. The above failure can probably also happen with Ninja given a sufficient number of build jobs.

[0] https://github.com/michaelforney/samurai

jnsh commented 3 years ago

Thank you for the fix!

The actual bug seems to be that the gresource custom_target should depend on every individual object from gtk3_assets and gtk3_hidpi_assets, but since they weren't added to an array, both depends only consisted of a single object. This is certainly a bug with ninja as well, even if it hasn't resulted in build failures yet.

Could you maybe be a bit more specific on the commit message about what this actually fixes. It doesn't hurt to mention that this caused a build failure with samurai, but the main thing is the dependency fix for the gresource target.

Also, please prepend the first line of the commit message with e.g. build/gtk3:, and add a full URL to this pull request at the end, as requested in HACKING.md.

ghost commented 3 years ago

Done.

jnsh commented 3 years ago

Excellent! Thank you once again!