Implement $accent-color and other variables in libadwaita

archisman-panigrahi commented 2 years ago

Details

Distribution and version: Manjaro XFCE (fully updated as of 3rd April 2022).
Versions for the affected applications/desktops/toolkits: blanket (GTK4/libadwaita)
Installation method (package or compiled manually): master branch compiled manually from github - commit https://github.com/rafaelmardojai/blanket/commit/cb28ca358110425aee207613a32d524faea41f57
Arc-theme version: Git commit https://github.com/jnsh/arc-theme/commit/f4e1593262927d68b5ac98968b1e3ec876fdf9b1

Blanket uses the variable accent-colors in its css file, and arc theme does not have it. As a result, icons of the active sounds are shown in white (almost invisible) in Arc theme, while they are nicely visible in libadwaita.

default libadwaita theme

libadwaita

Arc theme

arctheme

accent-color is a property of libadwaita, which matches the accent color choosen in the gnome system settings.

I don't know much css, but a possible solution would be to globally define the variable accent-color == the-blue-color-used-in-arc-theme in the css files of arc theme.

jnsh commented 2 years ago

Thanks for the report. I noticed the new color definitions when working on libadwaita, but forgot to add them. I'll sort this out soon :)

accent-color is a property of libadwaita, which matches the accent color choosen in the gnome system settings.

For reference, the libadwaita specific color properties that can be used by applications are defined in _defaults.scss, _colors.scss just defines the SASS color variables. There are some additional properties in _compat-colors.scss, that I think are part of the default GTK4 theme as well.

jnsh commented 2 years ago

This is fixed with https://github.com/jnsh/arc-theme/commit/4411abeb3d2dbd7b3c8b5a42f259d4d29c3fd993

archisman-panigrahi commented 2 years ago

Great!!! I can confirm that the issue is fixed.

yochananmarqos commented 2 years ago

Unfortunately this will not work in GNOME 42. Libadwaita applications use the global system theme and only "legacy" applications will use the selected custom theme.

EDIT: It does work on GNOME 42 using the GTK_THEME variable launching an application; i.e.,

GTK_THEME=Arc-Dark blanket

However, it does not work as a global variable.

jnsh commented 2 years ago

@yochananmarqos That's not what this issue was about, so this is not the right place for that discussion.

However, GNOME version doesn't matter with libadwaita applications, and setting the GTK_THEME environment variable globally does work.

yochananmarqos commented 2 years ago

@jnsh Sorry about the noise, then. The global variable does work, turns out I had a typo.

jnsh / arc-theme