jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
889 stars 79 forks source link

Shell 42 - Notification window is squared and contents are not aligned #185

Closed TJonCooper closed 2 years ago

TJonCooper commented 2 years ago

Distribution: Ubuntu 22.04 Arc-Theme compiled manually (pulled ~5m ago from master) for gtk3,gtk4,gnome-shell Variant: arc-dark

Steps to reproduce:

Initiate any notification e.g.:

notify-send "Test Title" "Blah blah blah blah"

The notification window is almost completely squared (whereas natively in Shell 40/41/42 it has rounded corners) and the notification icons are not aligned with the text.

Screenshot-20220429103850-607x97

The squared window issue is something seen throughout most of arc-theme on Shell 42 at the moment.

jnsh commented 2 years ago

The almost-square corners has always been an intentional design in Arc theme. 2-3px radius corners are used all across the theme. Increasing that to something more similar with default shell theme on single element (notifications), would only add major inconsistency to the theme. Changing the radius all across the theme would be major change to the visual design, and won't be done.

The notification icon is supposed to be aligned with the title (this is what the default shell theme used to do, therefore what Arc shell theme has always done). There is a clear misalignment, that I had not noticed as it is perfectly aligned with the 0.9 font scaling setting I've been using. I'll look at fixing this some time soon.

jnsh commented 2 years ago

The notification icon is aligned better with https://github.com/jnsh/arc-theme/commit/b13cff7b1a24bfb37ddccfb3f2ac868c0d835efd. However, how it actually aligns with the title depends on things like the used font, and font scaling.