search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
901 stars 77 forks source link

Notifications color changed after updating xfce4-notifyd #35

Closed malnvenshorn closed 4 years ago

malnvenshorn commented 4 years ago

The color of the notifications changed after updating xfce4-notifyd from version 0.4.4 to 0.6.0. I'm using arc-darker.

With 0.6.0:

1

With 0.4.4:

2

I'd like to get the dark notifications back when using arc-darker.

Btw. it's awesome that you still maintain this theme!

imShara commented 4 years ago

@malnvenshorn move notification-related code from arc-dark to ark-darker

jnsh commented 4 years ago

Thanks for the report. I'll look into this.

I'd like to get the dark notifications back when using arc-darker.

Just for clarification: In the screenshots you posted, the notifications are dark with 0.6.0, and light with 0.4.4. Did you post the screenshots the wrong way around?

malnvenshorn commented 4 years ago

Did you post the screenshots the wrong way around?

Yes indeed. I updated my post.

jnsh commented 4 years ago

I added styling for xfce4-notifyd notifications in https://github.com/jnsh/arc-theme/commit/b7973a859d32eee7ea8e460b536759133719bb73 that addresses this.

Please let me know if that results in any regressions, is missing features, or causes any other issues with the notifications.

malnvenshorn commented 4 years ago

What I've noticed is that the buttons are still white.

Bildschirmfoto_2020-04-17_09-44-09

jnsh commented 4 years ago

@malnvenshorn Thanks, I completely forgot about the buttons.

They should be now styled correctly with https://github.com/jnsh/arc-theme/commit/0779e1ca84141d8b443cf3e60b85307a145169b6.

malnvenshorn commented 4 years ago

Looks good now. Thank you :+1:

jnsh commented 4 years ago

I suppose this can be closed.

If you notice any other issues with the notifications, or anything else in general, please let me know. I'm not using xfce4 desktop myself, so it's always possible I've missed something obvious, even though I try to be thorough with my testing.

Thanks again.