search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

Search button weird on nautilus gnome 3.38 #85

Closed daniel88ferreira closed 3 years ago

daniel88ferreira commented 3 years ago

Hello,

Just updated to gnome 3.38 and search button on files (nautilus) moved more or less to the middle. With arc theme it looks weird: Screenshot from 2020-10-06 22-42-16

I am not a fan of the Adwaita solution, but it looks better: image

Thanks! And thanks for the great work!

jnsh commented 3 years ago

Thanks for the report. I had already looked at this, but unfortunately there's no simple fix.

The search button placement itself has nothing to do with the theme. Nautilus added some spacing between it and rest of the header buttons, as part of the path-bar refactoring. I'm not a big fan of this either, although I understand the reasoning. There is an open nautilus issue about this.

The solution would be adding some background and borders for the overall path-bar area, similarly that was done for the "maximized" path-bar in earlier versions, and how the Adwaita specific nautilus styling was done, as seen in the screenshot you provided.

The problem is that it's not possible to style nautilus 3.36 and 3.38 separately in custom GTK themes, and implementing the above fix would alter/break the path-bar styling for pre-3.38 versions.

For that reason the fix requires some further testing and consideration, but I'm hoping to get some kind of solution pushed soon.