jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

Windows jump when entering & leaving shell overview #87

Closed keynslug closed 3 years ago

keynslug commented 3 years ago

Before submitting

Details

See screencast.

At the end of leave overview animation windows noticably "jump" into place. At the start of enter overview animation there's similar jump though less pronounced.

Just to be sure I ran a fresh shell once more with all extensions disabled (except user themes obviously), the effect is still the same. To make screencast recording clearer I slowed down animations 3 times with Impatience extension.

font-size-patch

Added for completeness, hovewer I reproduced the issue without it applied as well.

diff --git a/common/gnome-shell/3.38/sass/_common.scss b/common/gnome-shell/3.38/sass/_common.scss
index 51f0bca..2068c9d 100644
--- a/common/gnome-shell/3.38/sass/_common.scss
+++ b/common/gnome-shell/3.38/sass/_common.scss
@@ -33,7 +33,7 @@ $asset_path: assets;
 //
 // Globals
 //
-$font-size: 11;
+$font-size: 9;
 $_bubble_bg_color: opacify($osd_bg_color,0.25);
 $_bubble_fg_color: $osd_fg_color;
 $_bubble_borders_color: transparentize($osd_fg_color,0.8);

EDIT 1: Added screen resolution, just in case.

jnsh commented 3 years ago

Thanks for the report. I had actually noticed this myself, but didn't even consider that it could result from the shell theme. I'll try to figure out a fix..

drakkar1969 commented 3 years ago

I have the same issue. It appears to be caused by a padding property in the #overview section of the gnome shell SCSS. I would be happy to submit a PR for this, if ok by you @jnsh

jnsh commented 3 years ago

I would be happy to submit a PR for this, if ok by you @jnsh

That would be great. Thanks :)

keynslug commented 3 years ago

Nice work!