search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

gnome-shell: Fix window "jump" issue when entering/leaving overview (3.38) #88

Closed drakkar1969 closed 3 years ago

drakkar1969 commented 3 years ago

Fixes https://github.com/jnsh/arc-theme/issues/87. The issue with windows "jumping" when entering/leaving the overview is caused by the padding property in the .window-picker code block:

.window-picker { //container around window thumbnails
  spacing: 6px;
  padding: 0 12px 12px;

  &.external-monitor { padding: 12px; }
}

The whole block of code appears to be obsolete, and should be removed, IMO (not present in upstream code).

jnsh commented 3 years ago

The whole block of code appears to be obsolete, and should be removed, IMO (not present in upstream code).

This is not correct, the .window-picker styling is still present in default shell SCSS. If that wasn't the case, it should be removed, but in that situation it couldn't really cause any problems either.

Changing the .window-picker padding from padding: 0 12px 12px; to padding: 12px; as per upstream, seems to fix the issue however.

drakkar1969 commented 3 years ago

Correct, sorry, the split of code into widgets is killing me ... Commit corrected, and solution also working for me

jnsh commented 3 years ago

Correct, sorry, the split of code into widgets is killing me ...

No worries... The split widget SCSS is indeed a bit annoying if you don't want to clone the whole repo, and since you can't grep in the gitlab web interface either (at least afaik).

Thank you for figuring out the fix for this!