search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

gnome-shell: Add border around user icon (3.38.1) #91

Closed drakkar1969 closed 3 years ago

drakkar1969 commented 3 years ago

Border around user icons (avatars) added in upstream code in GNOME shell point release 3.38.1.

An additional change in the upstream code that removes specific styling for the polkit dialog user icon is not yet included in the 3.38.1 point release, but it could makes sense to add to the Arc theme as of now (https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/9d5165b1aa5ad11662c9c02cbf161fd7004e3f05) (this would break styling right now)

jnsh commented 3 years ago

I was aware of this change for default shell theme, but I'm not sure whether a border around the icon makes sense in the flatter visual design of Arc, at least for the login screen. If there's a practical reason for this, I think the border should at least use the standard border width and color, or some other more subtle color.

Let me know if you have any more thoughts about this, but currently I'm leaning against merging.

I should also have another look at the Arc login/unlock screen styling at some point, so I can give this some more consideration when that happens.

drakkar1969 commented 3 years ago

Honestly, I do not feel strongly about this one. One could look at a more subtle border, but would then probably look out of place in the unlock screen. Don't think it's worth exploring further until upstream changes allowing separate styling of the unlock screen come online.