jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

gnome-shell: Search results not aligned in overview #92

Closed drakkar1969 closed 3 years ago

drakkar1969 commented 3 years ago

gnome-shell 3.38.1, latest git version of Arc theme

Search results in the overview have different vertical alignments, resulting in different sizes of highlight boxes. This only seems to affect system actions (e.g. restart/power off):

search-alignment

I have narrowed down issue to the @extend %icon_tile code in this block:

.app-well-app,
.app-well-app.app-folder,
.grid-search-result {

  .overview-icon {
    @extend %icon_tile;
  }
  ...
}

The issue can be solved by deleting the padding property from the %icon-tile snippet:

%icon_tile {
  color: $_shell_fg_color;
  border-radius: 2px;
  padding: 6px;
  border: 1px solid transparent;
  transition-duration: 0ms;
  text-align: center;
}

However, I don't think simply deleting the padding property is the way to go, since it is present in the upstream code.

jnsh commented 3 years ago

Thanks, this was rather tricky, but I managed to figure out the culprit with looking glass.

Apparently this used to be the case also for the default shell theme, and got fixed (intentionally or not) during the 3.36 refactor. I should go trough the Arc shell theme and refactor it against the current upstream to fix other similarly outdated bits, but there's some major GTK work that I have to get done first.

drakkar1969 commented 3 years ago

Thanks! Nice fix