search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

gnome-shell: Fix some over large font sizes #93

Closed drakkar1969 closed 3 years ago

drakkar1969 commented 3 years ago

Likely as a result of the shell font size being changed from 9pt to 11pt (https://github.com/jnsh/arc-theme/commit/e672981af6dff3e7896310aa8118ff01624a9538) just after the commit to streamline font sizes with the font mixin (https://github.com/jnsh/arc-theme/commit/7c7aaa5be18d314b7e9a8cc2cb16d8dc3810791e), some font sizes in GNOME shell are visually too large - and significantly larger than upstream.

Affects the following classes:

.message-dialog-title
.message-dialog-title.lightweight
.folder-name-label / .folder-name-entry
.chat-meta-message
.word-suggestions
.keyboard-key

This PR reduces font sizes for selected classes to align with upstream (and fix visual appearance)

jnsh commented 3 years ago

Sorry about the delay.

This certainly makes sense. Only thing is that I'd prefer to always adjust the base $font-size by multiplication/division, rather than addition/substraction (i.e $font-size * n rather than $font-size + n), unless there's some known disadvantage form this. That way the font sizes would change uniformly if you adjust the $font-size variable in the code.

drakkar1969 commented 3 years ago

Only thing is that I'd prefer to always adjust the base $font-size by multiplication/division

Code amended. I had gone with addition/subtraction based on upstream code, but makes sense to use multiplication/division, as is done elsewhere in the Arc SCSS

jnsh commented 3 years ago

Merged. Thank you once again.