search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
902 stars 77 forks source link

INSTALL.md missing a build dependency #99

Closed chanster closed 3 years ago

chanster commented 3 years ago

OS: Ubuntu 20.04 (using docker)

When running a make install after installing listed dependencies, I get an error

...
/bin/bash: glib-compile-resources: command not found
make[3]: *** [Makefile:612: light/gtk.gresource] Error 127
rm light/gtk.gresource.xml light/assets
make[3]: Leaving directory '/arc-theme/common/gtk-3.0/3.24'
make[2]: *** [Makefile:456: install-recursive] Error 1
make[2]: Leaving directory '/arc-theme/common/gtk-3.0'
make[1]: *** [Makefile:465: install-recursive] Error 1
make[1]: Leaving directory '/arc-theme/common'
make: *** [Makefile:363: install-recursive] Error 1

After adding package libglib2.0-dev, make install completed without errors. Also On Ubuntu, seems automake doesn't install make, so I had to also install that.

Steps to reproduce:

docker run -it --rm ubuntu:20.04 bash
apt update
DEBIAN_FRONTEND=noninteractive apt install -y git autoconf make automake pkgconf sassc inkscape optipng
git clone https://github.com/jnsh/arc-theme --depth 1
cd arc-theme/
./autogen.sh --prefix=$HOME/.local --with-gtk3=3.24 --with-gnome-shell=3.36 --with-cinnamon=4.4
make install
jnsh commented 3 years ago

Thank you for the report. You're correct about both dependencies. I updated the build instruction to mention these.