jnthas / clockwise

do-it-yourself, full-featured and smart wall clock device
https://clockwise.page
MIT License
263 stars 34 forks source link

Connecting LDR #25

Closed anthonyjclarke closed 1 year ago

anthonyjclarke commented 1 year ago

Thanks for the great addition, can you please confirm how to connect the LDR to Pin35 for your code to operate?

Is it as per this ESP Trinity schematic?

image

https://github.com/witnessmenow/ESP32-Trinity/blob/master/hardware/ESP32Trinity/V1.2/Schematic_ESP32-Trinity_2021-08-27.png

jnthas commented 1 year ago

Hi Anthony. Sorry, it's exactly this. I'm going to update the documentation.

TheGroundZero commented 1 year ago

If you get the Trinity, is it a matter of just soldering the LDR on the provisioned pads?

Lofty73 commented 1 year ago

Yes just solder one to the marked position.

hallard commented 1 year ago

Awesome software, would be great to be able to select GPIO used for LDR in settings page to avoid users to recompile. I'm Author of an old OpenSource shield for ESP32 D1 Mini and as I wanted to keep compatibility with ESP8266 D1 Mini, LDR is connected to A0 AKA GPIO36 on ESP32 D1 Mini

jnthas commented 1 year ago

@anthonyjclarke I added the LDR wiring in the README @hallard Thanks for the feedback, I will put this change in the backlog. If you don't mind, I will link your shield as one of the options to run the Clockwise.

anthonyjclarke commented 1 year ago

Awesome software, would be great to be able to select GPIO used for LDR in settings page to avoid users to recompile.

I'm Author of an old OpenSource shield for ESP32 D1 Mini and as I wanted to keep compatibility with ESP8266 D1 Mini, LDR is connected to A0 AKA GPIO36 on ESP32 D1 Mini

+1 to this. I have some of Charles great boards as well as the I2S board from @witnessmenow boards and would like this flexibility

jnthas commented 1 year ago

I agree. I will include the option to configure the GPIO in the next release.

hallard commented 1 year ago

I agree. I will include the option to configure the GPIO in the next release.

Awesome, thanks 🙏

hallard commented 1 year ago

If you don't mind, I will link your shield as one of the options to run the Clockwise.

Of course you’re welcome